Skip to content

Fold packages into their Pub Workspace root in the "Select package to… - #6038

Merged
DanTup merged 1 commit into
masterfrom
group-packages-in-folder-picker
Apr 21, 2026
Merged

DanTup merged 1 commit into
masterfrom
group-packages-in-folder-picker

Conversation

@DanTup

@DanTup DanTup commented Apr 21, 2026

Copy link
Copy Markdown
Member

… run x in" picker

For commands like "pub get" that operate on a Pub Workspace, we shouldn't ask the user to pick a single package within that workspace. Instead, show "Pub Workspace, x packages" under a single entry for the root.

Fixes #6034

@DanTup DanTup added this to the v3.134.0 milestone Apr 21, 2026
@DanTup DanTup added is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. in commands Relates to commands (usually invoked from the command Palette) labels Apr 21, 2026
@DanTup
DanTup requested a review from Copilot April 21, 2026 14:56
gemini-code-assist[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

This comment was marked as resolved.

@codecov

codecov Bot commented Apr 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.92593% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.37%. Comparing base (c7c4a86) to head (c79bdf7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/extension/commands/packages.ts 33.33% 6 Missing ⚠️
src/extension/utils/vscode/projects.ts 80.00% 1 Missing and 2 partials ⚠️
src/extension/commands/flutter.ts 0.00% 2 Missing ⚠️
src/extension/commands/sdk.ts 83.33% 1 Missing ⚠️
src/shared/vscode/pub.ts 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6038      +/-   ##
==========================================
+ Coverage   69.29%   69.37%   +0.08%     
==========================================
  Files         171      171              
  Lines       12931    12958      +27     
  Branches     2577     2590      +13     
==========================================
+ Hits         8960     8990      +30     
+ Misses       3487     3481       -6     
- Partials      484      487       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanTup
DanTup force-pushed the group-packages-in-folder-picker branch from d0baaf7 to 56a6ec2 Compare April 21, 2026 17:08
devin-ai-integration[bot]

This comment was marked as resolved.

@DanTup
DanTup force-pushed the group-packages-in-folder-picker branch from 56a6ec2 to cd4c32d Compare April 21, 2026 17:22
devin-ai-integration[bot]

This comment was marked as resolved.

… run x in" picker

For commands like "pub get" that operate on a Pub Workspace, we shouldn't ask the user to pick a single package within that workspace. Instead, show "Pub Workspace, x packages" under a single entry for the root.

Fixes #6034
@DanTup
DanTup force-pushed the group-packages-in-folder-picker branch from cd4c32d to c79bdf7 Compare April 21, 2026 17:45
@DanTup
DanTup merged commit c7379ba into master Apr 21, 2026
26 checks passed
@DanTup
DanTup deleted the group-packages-in-folder-picker branch April 21, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in commands Relates to commands (usually invoked from the command Palette) is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pub: Get Packages shouldn't list all packages in the same workspace since they perform the same action

2 participants