Repository navigation
Add tests for "flutter create" settings editor - #6041
Merged
Merged
Conversation
DanTup
added
the
is testing
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request exposes the promptForNameWithSettings method as public and adds it to the FlutterCommandHandler interface. It also introduces a comprehensive suite of tests for the settings editor, including helper functions to stub VS Code's InputBox and QuickPick components to simulate user interactions. These tests verify that various setting types, such as organization strings, enums, booleans, and multi-enum platforms, are correctly updated. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6041 +/- ##
==========================================
+ Coverage 69.58% 70.18% +0.60%
==========================================
Files 171 171
Lines 12958 12958
Branches 2590 2590
==========================================
+ Hits 9017 9095 +78
+ Misses 3451 3378 -73
+ Partials 490 485 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DanTup
force-pushed
the
settings-editor-tests
branch
from
April 22, 2026 14:19
1a1f0c1 to
95c7327
Compare
DanTup
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6025