Repository navigation
Ensure exposeUrl() always has a logger, and always call it open opening DevTools in a browser - #6051
Merged
Merged
Conversation
DanTup
added
is enhancement
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes the logger parameter mandatory for the exposeUrl and exposeWebViewUrls functions to improve troubleshooting for URL mapping issues. This change is propagated through various components, including the DevTools manager, sidebar providers, and property editors, ensuring consistent logging across the extension. I have no feedback to provide as there were no review comments to assess.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6051 +/- ##
==========================================
- Coverage 70.54% 70.51% -0.04%
==========================================
Files 171 171
Lines 12971 12971
Branches 2589 2589
==========================================
- Hits 9150 9146 -4
- Misses 3334 3338 +4
Partials 487 487 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ng DevTools in a browser Might help debug flutter/devtools#9827
DanTup
force-pushed
the
improve-expose-url-logging
branch
from
May 12, 2026 17:43
e8c8784 to
87b5760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might help debug flutter/devtools#9827