Skip to content

Switch to LSP client vNext and re-enable delayOpenNotifications - #6069

Merged
DanTup merged 2 commits into
masterfrom
lsp-client-vnext
Jun 2, 2026
Merged

DanTup merged 2 commits into
masterfrom
lsp-client-vnext

Conversation

@DanTup

@DanTup DanTup commented Jun 2, 2026

Copy link
Copy Markdown
Member

Fixes #5176

DanTup added 2 commits June 2, 2026 10:42
This will let us try delayOpenNotifications again.

See #5176
@DanTup DanTup added this to the v3.138.0 milestone Jun 2, 2026
@DanTup DanTup added is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. in editor Relates to code editing or language features is performance labels Jun 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vscode-languageclient dependency to a pre-release version (10.0.0-next.22) and enables the delayOpenNotifications setting in the LSP analyzer to prevent unnecessary didOpen/didClose events during hover previews. The review feedback suggests updating vscode-languageclient to a stable version (e.g., ^10.0.0) if available, to avoid stability risks associated with pre-release versions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread package.json
"minimatch": "^10.2.4",
"semver": "^7.7.1",
"vscode-languageclient": "^9.0.1",
"vscode-languageclient": "10.0.0-next.22",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning a production dependency to a specific pre-release version (10.0.0-next.22) can introduce stability risks and prevents automatic upgrades to the stable release of vscode-languageclient v10 once it becomes available.

If the stable 10.0.0 version of vscode-languageclient has been released, please update this dependency to use the stable version (e.g., ^10.0.0). If you must use the pre-release version for now, consider adding a TODO comment or tracking issue to upgrade to the stable release as soon as possible.

Suggested change
"vscode-languageclient": "10.0.0-next.22",
"vscode-languageclient": "^10.0.0",

@DanTup
DanTup merged commit 6eef261 into master Jun 2, 2026
25 checks passed
@DanTup
DanTup deleted the lsp-client-vnext branch June 2, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in editor Relates to code editing or language features is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. is performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable delayOpenNotifications=true with LSP client vNext to prevent redundant didOpen/didClose notifications to server

1 participant