Repository navigation
Switch to LSP client vNext and re-enable delayOpenNotifications - #6069
Conversation
This will let us try delayOpenNotifications again. See #5176
There was a problem hiding this comment.
Code Review
This pull request updates the vscode-languageclient dependency to a pre-release version (10.0.0-next.22) and enables the delayOpenNotifications setting in the LSP analyzer to prevent unnecessary didOpen/didClose events during hover previews. The review feedback suggests updating vscode-languageclient to a stable version (e.g., ^10.0.0) if available, to avoid stability risks associated with pre-release versions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "minimatch": "^10.2.4", | ||
| "semver": "^7.7.1", | ||
| "vscode-languageclient": "^9.0.1", | ||
| "vscode-languageclient": "10.0.0-next.22", |
There was a problem hiding this comment.
Pinning a production dependency to a specific pre-release version (10.0.0-next.22) can introduce stability risks and prevents automatic upgrades to the stable release of vscode-languageclient v10 once it becomes available.
If the stable 10.0.0 version of vscode-languageclient has been released, please update this dependency to use the stable version (e.g., ^10.0.0). If you must use the pre-release version for now, consider adding a TODO comment or tracking issue to upgrade to the stable release as soon as possible.
| "vscode-languageclient": "10.0.0-next.22", | |
| "vscode-languageclient": "^10.0.0", |
Fixes #5176