Skip to content

Update Move-to-File refactor tests to test both with/without Interactive Forms - #6082

Merged
DanTup merged 1 commit into
interactive-formsfrom
interactive-forms-update-move-tests
Jun 10, 2026
Merged

DanTup merged 1 commit into
interactive-formsfrom
interactive-forms-update-move-tests

Conversation

@DanTup

@DanTup DanTup commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@DanTup DanTup added this to the v3.138.0 milestone Jun 10, 2026
@DanTup DanTup added the is testing Relates to the testing (either manual or automated) of Dart Code label Jun 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the experimental Interactive Forms feature for Dart refactors, adding a configuration setting dart.experimentalInteractiveForms, a capability check for Dart version compatibility, and corresponding test cases for moving top-level classes with and without interactive forms enabled. Feedback suggests a minor grammatical improvement in the configuration description and recommends wrapping the test bodies in try/finally blocks to guarantee that temporary test files are cleaned up even if assertions fail.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread package.json Outdated
Comment thread src/test/dart/refactors/move_top_level_to_file.test.ts
Comment thread src/test/dart/refactors/move_top_level_to_file.test.ts
@DanTup
DanTup force-pushed the interactive-forms-update-move-tests branch from 729e019 to cd34c0d Compare June 10, 2026 16:01
@codecov

codecov Bot commented Jun 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.14%. Comparing base (bef1492) to head (cd34c0d).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           interactive-forms    #6082      +/-   ##
=====================================================
+ Coverage              70.11%   70.14%   +0.03%     
=====================================================
  Files                    173      173              
  Lines                  13234    13235       +1     
  Branches                2661     2661              
=====================================================
+ Hits                    9279     9284       +5     
+ Misses                  3456     3453       -3     
+ Partials                 499      498       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanTup
DanTup merged commit 3c83172 into interactive-forms Jun 10, 2026
23 of 24 checks passed
@DanTup
DanTup deleted the interactive-forms-update-move-tests branch June 10, 2026 16:53
@DanTup DanTup modified the milestones: v3.138.0, v3.140.0 Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is testing Relates to the testing (either manual or automated) of Dart Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant