Skip to content

Enable interactive forms by default, inverting and renaming the previous experiment flag - #6107

Merged
DanTup merged 1 commit into
masterfrom
enable-interactive-forms
Jun 30, 2026
Merged

DanTup merged 1 commit into
masterfrom
enable-interactive-forms

Conversation

@DanTup

@DanTup DanTup commented Jun 30, 2026

Copy link
Copy Markdown
Member

Rather than just deleting the flag, keep it around inverted for a little while so if any issues crop up, users can easily disable it (either to avoid them, or to confirm whether it's related to interactive forms).

@DanTup DanTup added this to the v3.140.0 milestone Jun 30, 2026
@DanTup DanTup added is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. in editor Relates to code editing or language features labels Jun 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request promotes the experimental interactive forms feature to a stable configuration setting named 'dart.interactiveForms' and enables it by default. However, in 'src/extension/analysis/analyzer.ts', the activation logic was incorrectly inverted to 'if (!config.interactiveForms)'. This bug should be resolved by removing the negation operator so that the feature is registered when enabled.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/extension/analysis/analyzer.ts Outdated
@codecov

codecov Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.15%. Comparing base (f3fc09f) to head (0414fbd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6107      +/-   ##
==========================================
+ Coverage   71.13%   71.15%   +0.02%     
==========================================
  Files         170      170              
  Lines       13079    13079              
  Branches     2626     2626              
==========================================
+ Hits         9304     9307       +3     
+ Misses       3265     3262       -3     
  Partials      510      510              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ous experiment flag

Rather than just deleting the flag, keep it around inverted for a little while so if any issues crop up, users can easily disable it (either to avoid them, or to confirm whether it's related to interactive forms).
@DanTup
DanTup force-pushed the enable-interactive-forms branch from a23b800 to 0414fbd Compare June 30, 2026 14:07
@DanTup
DanTup merged commit 48ceb9e into master Jun 30, 2026
25 checks passed
@DanTup
DanTup deleted the enable-interactive-forms branch June 30, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in editor Relates to code editing or language features is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant