Skip to content

Don't run dart test tests both by line + by name if they are not affected by location/invocation mode - #6195

Merged
DanTup merged 1 commit into
masterfrom
extract-tests-from-loop
Sep 23, 2026
Merged

DanTup merged 1 commit into
masterfrom
extract-tests-from-loop

Conversation

@DanTup

@DanTup DanTup commented Sep 23, 2026

Copy link
Copy Markdown
Member

Similar to what 1fb5381 did for Flutter, this does the same for Dart. Test runs that aren't affected by whether we run by line or name don't need to be run twice inside the loop.

See #6165

@DanTup DanTup added this to the v3.144.0 milestone Sep 23, 2026
@DanTup DanTup added the is testing Relates to the testing (either manual or automated) of Dart Code label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.79%. Comparing base (8110e58) to head (b650f6c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6195      +/-   ##
==========================================
- Coverage   70.81%   70.79%   -0.02%     
==========================================
  Files         170      170              
  Lines       13191    13191              
  Branches     2657     2657              
==========================================
- Hits         9341     9339       -2     
  Misses       3327     3327              
- Partials      523      525       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…cted by location/invocation mode

Similar to what 1fb5381 did for Flutter, this does the same for Dart. Test runs that aren't affected by whether we run by line or name don't need to be run twice inside the loop.

See #6165
@DanTup
DanTup force-pushed the extract-tests-from-loop branch from b650f6c to 4ee88ce Compare September 23, 2026 11:24
@DanTup
DanTup merged commit e984136 into master Sep 23, 2026
20 checks passed
@DanTup
DanTup deleted the extract-tests-from-loop branch September 23, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is testing Relates to the testing (either manual or automated) of Dart Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant