Skip to content

Don't assume () on end of method calls #687

Closed

Description

@DanTup

See here: https://youtu.be/O7TXamVRSbY?t=41m43s

Putting parens on the end of methods isn't always appropriate. Plus, if we remove these and handle them as a triggerCharacter, it might address the other issue we had with duplicated parens.

Activity

  1. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in editorRelates to code editing or language features
    on Mar 12, 2018
  2. added this to the v2.11.0 milestone on Mar 12, 2018
  3. DanTup commented on Mar 14, 2018

    @DanTup
    MemberAuthor

    This might be worth tackling after signature information, since the best fix is going to be to totally remove insertArgumentPlaceholders and then add ( as a commit character.

  4. modified the milestones: v2.11.0, Backlog on Mar 14, 2018
  5. modified the milestones: Backlog, v2.17.0 on Jul 17, 2018
  6. DanTup commented on Jul 26, 2018

    @DanTup
    MemberAuthor

    The fix here is to turn off insertArgumentPlaceholders (and turn on completionCommitCharacters), but that's not perfect without signature help.

  7. modified the milestones: v2.17.0, v2.18.0 on Jul 30, 2018
  8. DanTup commented on Aug 22, 2018

    @DanTup
    MemberAuthor

    I'm considering this "kinda fixed".

    If you turn off insertArgumentPlaceholders then we won't ever do this. And if you turn on commit characters, then if you commit with ( then you'll get your parens. It's not perfect because commit characters are frustrating due to VS Code's fuzzy matching, but that's another issue.

  9. removed this from the v2.18.0 milestone on Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions