Support "format selection" [LSP] #812

Activity

1. DanTup commented on Apr 18, 2018

   

   DanTup

   on Apr 18, 2018

   Member

   More actions

   I can't find any information on what the vim command = is supposed to do - can you provide more info about this? (I think a VsCodeVim extension, but I can't find any docs suggesting that = is related to formatting).

   If you click Format Document in the context menu, does that work? If so, my guesses are:

   1. Something is buggy with the vim extension
   2. It's trying to format a selection, which isn't supported by Dart (requires Support formatting of source selections dart-lang/dart_style#92)
2. DanTup

   added

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Apr 18, 2018
3. partounian commented on Apr 18, 2018

   

   partounian

   on Apr 18, 2018

   Last edited by partounian

   Author

   More actions

   = if used in vim for formatting though it is required to choose a selection (the selection can be the entire file with gg=G [go to top of file, format until bottom]). Format document does work, so it is safe to assume this is related to dart-lang/dart_style#92 . Safe to assume we can close this then as it's basically a duplicate.
4. partounian

   closed this as completedon Apr 18, 2018
5. DanTup

   added

   blocked on dart / flutterRequires a change in Dart or Flutter to progressRequires a change in Dart or Flutter to progress

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   in editorRelates to code editing or language featuresRelates to code editing or language features

   and removed

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Apr 18, 2018
6. DanTup

   added this to the Backlog milestone on Apr 18, 2018
7. DanTup

   changed the title [-]There is no formatter for 'dart'-files installed. (vim vscodevim plugin)[/-] [+]Support "format selection"[/+] on Apr 18, 2018
8. DanTup commented on Apr 18, 2018

   

   DanTup

   on Apr 18, 2018

   Member

   More actions

   Seems like we actually don't have an open issue about this as a reminder, so I'm re-opening this and re-purposing it. If/when the above case is done, we will implement this (and in the meantime, this case can serve as a reminder of something we want to do but are blocked on).

   👍React with 👍8Reacted by Patrick Artounian, Levi Brown, Greg Spencer, cielo, Dmitry Ivanov, Jose Blanco, LaZyQ and Mayur Dhurpate
9. DanTup

   reopened this on Apr 18, 2018
10. DanTup

    added

    in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

    on Jun 1, 2020
11. DanTup

    removed

    blocked on dart / flutterRequires a change in Dart or Flutter to progressRequires a change in Dart or Flutter to progress

    on Nov 12, 2020
12. DanTup

    modified the milestones: Backlog, v3.17.0 on Nov 12, 2020
13. DanTup

    changed the title [-]Support "format selection"[/-] [+]Support "format selection" [LSP][/+] on Nov 12, 2020
14. dart-bot

    added a commit that references this issue on Nov 12, 2020

    [Analyzer] Add LSP support for Format Selection/Range

    ...

    44e680a
15. DanTup commented on Nov 12, 2020

    

    DanTup

    on Nov 12, 2020

    Member

    More actions

    Fixed by dart-lang/sdk@44e680a.
16. DanTup

    closed this as completedon Nov 12, 2020