Skip to content

Only select ephemeral devices - #1807

Merged
DanTup merged 4 commits into
masterfrom
improve-device-handling
Jun 20, 2019
Merged

DanTup merged 4 commits into
masterfrom
improve-device-handling

Conversation

@DanTup

@DanTup DanTup commented Jun 20, 2019

Copy link
Copy Markdown
Member

For older versions we just treat every device as auto-selectable, but when Flutter tells us a device is not ephemeral (Desktop/Web) we don't auto-select it unless there are no other devices.

This can be improved further (only auto-select if it's valid for an open project), but this will at least avoid the issue where a desktop device is selected upon opening a project if the mobile is already connected (the devices come through with mobile first, desktop second).

@DanTup DanTup added is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. in flutter Relates to running Flutter apps labels Jun 20, 2019
@DanTup DanTup added this to the v3.2.0 milestone Jun 20, 2019
@DanTup
DanTup merged commit b82e4f2 into master Jun 20, 2019
@DanTup
DanTup deleted the improve-device-handling branch June 20, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in flutter Relates to running Flutter apps is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant