Repository navigation
Conversation
| ], | ||
| "default": null, | ||
| "markdownDescription": "The path to a log file for very detailed logging in the Dart Analysis Server that may be useful when trying to diagnose Analysis Server issues. Use `${workspaceName}` to insert the name of the current workspace in the file path.", | ||
| "markdownDescription": "The path to a log file for very detailed logging in the Dart Analysis Server that may be useful when trying to diagnose Analysis Server issues. Use `${name}` in the log file name to insert the Debug Session name to prevent concurrent debug sessions overwriting each others logs. Use `${workspaceName}` to insert the name of the current workspace in the file path.", |
There was a problem hiding this comment.
${name} isn't supported here, it's only supported in the loges that are debug-session specific (that is DAP, DartTest, FlutterRun, FlutterTest, WebDaemon).
I think as of the current master version, the descriptions should all be accurate.
| setupLog(config.analyzerLogFile, LogCategory.Analyzer); | ||
| setupLog(config.flutterDaemonLogFile, LogCategory.FlutterDaemon); | ||
| setupLog(config.toolingDaemonLogFile, LogCategory.DartToolingDaemon); | ||
| setupLog(config.dapLogFile, LogCategory.DAP); |
There was a problem hiding this comment.
This seems to be reverting some changes I just pushed to master to support "dynamic" DAP log file names.
| import { CategoryLogger } from "../../shared/logging"; | ||
|
|
||
| export class DartDebugAdapterLoggerFactory implements DebugAdapterTrackerFactory { | ||
| constructor(private readonly logger: EmittingLogger) { } |
There was a problem hiding this comment.
Same here and below, I think you've reverted this PR to before my changes so it's trying to undo them.
|
Since I'm not sure how to fix this besides going through every file changed and fixing them by hand, I'll recreate this PR with only the changes for |
|
sgtm - though it's not clear to me what still needs fixing - I thought I'd updated everything to be accurate in my last few changes (I didn't see you were also working on these until afterwards unfortunately!). |
I see what you mean then. The only thing my PR would add is more consistency between all of the descriptions and a typo fix. Will rename it then. Here it is #5188. |
2 participants
This PR is to address the following part of a comment I made:
Originally posted by @FMorschel in #5154 (comment)