Repository navigation
Remove many legacy settings - #5975
Conversation
- Removes many legacy settings that related to legacy analysis server protocol, legacy debug adapters, SDKs prior to the ones we support (Dart >=3.2, Flutter >= 3.16). Also: - ensures more please where we use `onDidChangeConfiguration` we check that the config we care about changed. - removes some settings from `getSettingsThatRequireRestart()` that don't require restarts because they are handled dynamically
DanTup
added
the
is enhancement
|
@codex review /gemini review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5975 +/- ##
==========================================
- Coverage 67.52% 67.49% -0.04%
==========================================
Files 169 169
Lines 12999 12974 -25
Branches 2571 2566 -5
==========================================
- Hits 8778 8757 -21
+ Misses 3762 3758 -4
Partials 459 459 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly cleans up legacy settings related to older analysis server protocols, debug adapters, and SDK versions, and improves performance by making onDidChangeConfiguration handlers more specific. No security vulnerabilities were found in these changes. The update also correctly removes dynamically handled settings from the list requiring an extension restart, enhancing maintainability and reducing technical debt.
onDidChangeConfigurationwe check that the config we care about changed.getSettingsThatRequireRestart()that don't require restarts because they are handled dynamicallyFixes #5972