Skip to content

Resolve a pubspec/package to its workspace before running "pub get" - #5996

Merged
DanTup merged 1 commit into
masterfrom
pub-get-always-workspace
Mar 23, 2026
Merged

DanTup merged 1 commit into
masterfrom
pub-get-always-workspace

Conversation

@DanTup

@DanTup DanTup commented Mar 23, 2026

Copy link
Copy Markdown
Member

We previously did this for "Pub Get for All Packages", but clicking buttons in pubspec.yamls or changing and saving should also do the same. This also fixes that we would try to touch() the files in the wrong place and therefore do nothing.

Fixes #5917

@DanTup DanTup added this to the v3.132.0 milestone Mar 23, 2026
@DanTup DanTup added the in commands Relates to commands (usually invoked from the command Palette) label Mar 23, 2026
@DanTup
DanTup requested a review from Copilot March 23, 2026 11:03
@DanTup

DanTup commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

/gemini review

gemini-code-assist[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.81%. Comparing base (5828296) to head (a5ec82d).

Files with missing lines Patch % Lines
src/shared/vscode/pub.ts 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5996      +/-   ##
==========================================
+ Coverage   67.72%   67.81%   +0.09%     
==========================================
  Files         170      170              
  Lines       12992    13008      +16     
  Branches     2574     2580       +6     
==========================================
+ Hits         8799     8822      +23     
+ Misses       3733     3724       -9     
- Partials      460      462       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment was marked as resolved.

We previously did this for "Pub Get for All Packages", but clicking buttons in pubspec.yamls or changing and saving should also do the same. This also fixes that we would try to touch() the files in the wrong place and therefore do nothing.

Fixes #5917
@DanTup
DanTup force-pushed the pub-get-always-workspace branch from a5ec82d to 622862f Compare March 23, 2026 11:24
@DanTup
DanTup merged commit 3c82ba0 into master Mar 23, 2026
22 checks passed
@DanTup
DanTup deleted the pub-get-always-workspace branch March 23, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in commands Relates to commands (usually invoked from the command Palette) is bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running pub get from explicit save or the Get Packages button places result in different output

2 participants