Skip to content

Fix handling of mixed SDK/Pub packages in "Add Dependency" - #6032

Merged
DanTup merged 1 commit into
masterfrom
fix-mixed-sdk-non-sdk-packages
Apr 16, 2026
Merged

DanTup merged 1 commit into
masterfrom
fix-mixed-sdk-non-sdk-packages

Conversation

@DanTup

@DanTup DanTup commented Apr 16, 2026

Copy link
Copy Markdown
Member

Fixes #6028

@DanTup DanTup added this to the v3.134.0 milestone Apr 16, 2026
@DanTup DanTup added is bug fix in commands Relates to commands (usually invoked from the command Palette) labels Apr 16, 2026
@DanTup
DanTup requested a review from Copilot April 16, 2026 12:58
gemini-code-assist[bot]

This comment was marked as resolved.

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@codecov

codecov Bot commented Apr 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.27%. Comparing base (e6b6ec2) to head (2a3fca5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/extension/commands/add_dependency.ts 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6032   +/-   ##
=======================================
  Coverage   69.26%   69.27%           
=======================================
  Files         171      171           
  Lines       12927    12931    +4     
  Branches     2575     2578    +3     
=======================================
+ Hits         8954     8958    +4     
+ Misses       3490     3489    -1     
- Partials      483      484    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanTup
DanTup force-pushed the fix-mixed-sdk-non-sdk-packages branch from 15dbecb to 234d032 Compare April 16, 2026 13:24
devin-ai-integration[bot]

This comment was marked as resolved.

@DanTup
DanTup force-pushed the fix-mixed-sdk-non-sdk-packages branch from 234d032 to 5d7dc3d Compare April 16, 2026 13:35
devin-ai-integration[bot]

This comment was marked as resolved.

@DanTup
DanTup force-pushed the fix-mixed-sdk-non-sdk-packages branch from 5d7dc3d to 2a3fca5 Compare April 16, 2026 13:58
@DanTup
DanTup merged commit db460c2 into master Apr 16, 2026
25 checks passed
@DanTup
DanTup deleted the fix-mixed-sdk-non-sdk-packages branch April 16, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in commands Relates to commands (usually invoked from the command Palette) is bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Add Dependency" doesn't handle flutter SDK checks properly for multiple packages

2 participants