Repository navigation
Improve handling of slow Flutter daemon responses - #6055
Merged
Merged
Conversation
DanTup
added
is enhancement
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Flutter daemon's timeout logic by introducing a dual-timeout mechanism: a 20-second caller timeout that returns a default value and a 2-minute hang timeout for error logging and reload prompts. The getEmulators and getSupportedPlatforms methods were updated to utilize this new structure. Review feedback identified a typo in a log message and recommended explicitly clearing the caller timeout timer upon promise resolution or rejection to improve resource management.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6055 +/- ##
==========================================
+ Coverage 70.54% 70.56% +0.01%
==========================================
Files 171 171
Lines 12971 12975 +4
Branches 2589 2589
==========================================
+ Hits 9151 9156 +5
+ Misses 3335 3333 -2
- Partials 485 486 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Previously after 20s we consider the daemon unresponsive and show a notification (and record an event). However, logs have been provided showing 40s responses if VS Code is opened at the same time as many other applications immediately after booting a MacBook. This change keeps the 20s timeout and returns a default response, but only shows the notification/records an event if there is no response for 2 minutes. This should avoid false alerts without potentially delaying anything where we've blocked the UI waiting on a response for a long period. Fixes #6048
DanTup
force-pushed
the
improve-timeout-handling
branch
from
May 14, 2026 10:16
b37aca1 to
dca9070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously after 20s we consider the daemon unresponsive and show a notification (and record an event). However, logs have been provided showing 40s responses if VS Code is opened at the same time as many other applications immediately after booting a MacBook.
This change keeps the 20s timeout and returns a default response, but only shows the notification/records an event if there is no response for 2 minutes.
This should avoid false alerts without potentially delaying anything where we've blocked the UI waiting on a response for a long period.
Fixes #6048