Repository navigation
Don't enqueue() entire test suite unless we know the whole suite is being run - #6093
Conversation
…eing run The fix for #5928 was to enqueue() an entire test suite when it started running. However, this meant that running even a single test would enqueue the entire test suite, and then when only one test ran, the others would all get marked as skipped. To fix this, we only enqueue() the whole suite in cases where we know we are running the entire suite (eg. you press `F5`). If you run a subset of tests, we do not. This does mean that if you run a _group_ then nothing gets enqueued (so you won't see the "waiting" status icons), but this seems to be the best trade-off we can make given that we don't have a concrete link between the debug session we start and what tests run (because of dynamic test names, etc.). Fixes #6091
DanTup
added
is bug fix
in testing
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a change to only enqueue an entire test suite when we are certain that the whole suite is being run (e.g., when running a file via F5) and the run was not initiated by the VS Code test runner. This is achieved by adding and setting an isRunningWholeSuite flag on SuiteData during flagSuiteStart. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6093 +/- ##
==========================================
+ Coverage 71.02% 71.05% +0.02%
==========================================
Files 172 172
Lines 13058 13060 +2
Branches 2608 2608
==========================================
+ Hits 9275 9280 +5
+ Misses 3286 3284 -2
+ Partials 497 496 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
The fix for #5928 was to enqueue() an entire test suite when it started running. However, this meant that running even a single test would enqueue the entire test suite, and then when only one test ran, the others would all get marked as skipped.
To fix this, we only enqueue() the whole suite in cases where we know we are running the entire suite (eg. you press
F5). If you run a subset of tests, we do not. This does mean that if you run a group then nothing gets enqueued (so you won't see the "waiting" status icons), but this seems to be the best trade-off we can make given that we don't have a concrete link between the debug session we start and what tests run (because of dynamic test names, etc.).Fixes #6091