Repository navigation
Don't send active location changes to DTD for anything that's not a real editor - #6104
Conversation
DanTup
added
is bug fix
in dtd
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies src/extension/dart/tooling_daemon.ts to filter out non-editor tabs (like output panes or test diffs) before sending active location updates. The reviewer identified a performance bottleneck, noting that this synchronous tab traversal runs on every keystroke before debouncing, and recommended moving the check inside the debounced function. Additionally, the reviewer pointed out a TypeScript compilation error due to a missing type predicate in the filter, providing a code suggestion to resolve both issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6104 +/- ##
==========================================
+ Coverage 71.02% 71.08% +0.05%
==========================================
Files 169 169
Lines 12835 12844 +9
Branches 2556 2557 +1
==========================================
+ Hits 9116 9130 +14
+ Misses 3232 3227 -5
Partials 487 487 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Fixes #6102