Repository navigation
Add an "auto" option for dart.testInvocatationMode that selects intelligently - #6191
Merged
Merged
Conversation
…ligently This adds an "auto" mode that is like "line" but will automatically fall back to "name" if: - the file is unsaved - the test name does not contain $ Fixes #5716
DanTup
added
is enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6191 +/- ##
==========================================
- Coverage 70.78% 70.76% -0.02%
==========================================
Files 170 170
Lines 13182 13191 +9
Branches 2655 2657 +2
==========================================
+ Hits 9331 9335 +4
- Misses 3327 3331 +4
- Partials 524 525 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The configuration and package defaults remain "name" instead of the requested "auto" default.
Review effort: Lite
Findings: None
What changed in this PR
Adds an auto Dart test invocation mode that selects line-based execution for saved dynamic tests and name-based execution otherwise.
Changes:
- Adds and documents the
autoconfiguration option. - Implements automatic invocation selection.
- Adds integration tests for the behavior.
| File | Summary |
|---|---|
src/test/dart_debug/dart_test.test.ts |
Tests automatic invocation behavior. |
src/extension/config.ts |
Adds the auto configuration mode. |
src/extension/commands/test.ts |
Implements automatic mode selection. |
package.json |
Exposes and documents the setting option. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an "auto" mode that is like "line" but will automatically fall back to "name" if:
Fixes #5716