Repository navigation
Conversation
|
@mohsen1 Thank you for submitting this PR! 🔔 @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh @eps1lon @Hannes-Magnusson-CK @jkomyno @ajafff @hoo29 - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@mohsen1 The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
ajafff
left a comment
There was a problem hiding this comment.
This is not documented in Node's docs and the underscore implies that it's private. The fact that it's used by some project doesn't mean it should be publicly available.
|
@ajafff marked as deprecated. It's a real API and lack of this property is blocking us migrating to TypeScript. What is the policy here? Are we not adding types for non-documented stuff? |
|
🔔 @ajafff - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
|
pinging @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh @eps1lon @Hannes-Magnusson-CK @jkomyno @ajafff @hoo29 |
|
I recommend to use a project local .d.ts file to access such internal, non documented APIs. |
|
Maybe we should not add this one. |
Being used here
https://github.com/webpack/webpack/blob/51b0df77e4f366163730ee465f01458bfad81f34/lib/NormalModule.js#L151
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
dts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.If removing a declaration:
notNeededPackages.json.