Skip to content

Add MultiHook and _pluginCompat to Tapable - #24527

Merged
mhegazy merged 6 commits into
DefinitelyTyped:masterfrom
mohsen1:fix-tapable
Mar 27, 2018
Merged

mhegazy merged 6 commits into
DefinitelyTyped:masterfrom
mohsen1:fix-tapable

Conversation

@mohsen1

@mohsen1 mohsen1 commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Mar 26, 2018
@typescript-bot

typescript-bot commented Mar 26, 2018 •

Copy link
Copy Markdown
Contributor

@mohsen1 Thank you for submitting this PR!

🔔 @e-cloud - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

Copy link
Copy Markdown
Contributor

@mohsen1 The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

@mohsen1 mohsen1 changed the title Fix Tapable types Add MultiHook and _pluginCompat to Tapable Mar 27, 2018
@mohsen1 mohsen1 mentioned this pull request Mar 27, 2018
27 tasks done
@mhegazy
mhegazy merged commit d5cbb8d into DefinitelyTyped:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants