Repository navigation
Ensures playerframework compiles with TS 4.4 - - #54090
Merged
Merged
Conversation
Contributor
|
@orta Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54090,
"author": "orta",
"headCommitOid": "6ea7c292ea5d693750f42995a639674079ec05b3",
"lastPushDate": "2021-06-25T17:13:52.000Z",
"lastActivityDate": "2021-06-25T17:14:54.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "playerframework",
"kind": "edit",
"files": [
{
"path": "types/playerframework/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ricardosabino"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 868713478,
"ciResult": "pass"
} |
Contributor
|
🔔 @ricardosabino — please review this PR in the next few days. Be sure to explicitly select |
Contributor
|
I just published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: microsoft/TypeScript#44684
I switched it from a type which doesn't exist anymore to an
any- I was tempted to remove all thems*methods but realized that this is really for a library which no one is probably using anymore - https://archive.codeplex.com/?p=playerframework, so weakening is probably a bit better than complete removal