Repository navigation
Make wicg-mediasessions work with TS 4.4 DOM - #54092
Conversation
TS 4.4 improves its types for MediaSesssion. This PR makes DT match those upcoming types. Needed after microsoft/TypeScript#44684 is merged.
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54092,
"author": "sandersn",
"headCommitOid": "a07b7113dc2b70a3b15671f33f56e9a32878dce8",
"lastPushDate": "2021-06-28T19:01:20.000Z",
"lastActivityDate": "2021-06-28T19:01:20.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "wicg-mediasession",
"kind": "edit",
"files": [
{
"path": "types/wicg-mediasession/index.d.ts",
"kind": "definition"
},
{
"path": "types/wicg-mediasession/wicg-mediasession-tests.ts",
"kind": "test"
}
],
"owners": [
"jucrouzet",
"blueset"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 868725481,
"ciResult": "pass"
} |
|
🔔 @jucrouzet @blueset — please review this PR in the next few days. Be sure to explicitly select |
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
I just published |
TS 4.4 improves its types for MediaSesssion. This PR makes DT match those upcoming types.
Needed after microsoft/TypeScript#44684 is merged.