Skip to content

Make wicg-mediasessions work with TS 4.4 DOM - #54092

Merged
sandersn merged 3 commits into
masterfrom
make-wicg-mediasession-work-with-4.4-dom
Jun 28, 2021
Merged

sandersn merged 3 commits into
masterfrom
make-wicg-mediasession-work-with-4.4-dom

Conversation

@sandersn

Copy link
Copy Markdown
Contributor

TS 4.4 improves its types for MediaSesssion. This PR makes DT match those upcoming types.

Needed after microsoft/TypeScript#44684 is merged.

TS 4.4 improves its types for MediaSesssion. This PR makes DT match those upcoming types.

Needed after microsoft/TypeScript#44684 is merged.
@typescript-bot

typescript-bot commented Jun 25, 2021 •

Copy link
Copy Markdown
Contributor

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54092,
  "author": "sandersn",
  "headCommitOid": "a07b7113dc2b70a3b15671f33f56e9a32878dce8",
  "lastPushDate": "2021-06-28T19:01:20.000Z",
  "lastActivityDate": "2021-06-28T19:01:20.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wicg-mediasession",
      "kind": "edit",
      "files": [
        {
          "path": "types/wicg-mediasession/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wicg-mediasession/wicg-mediasession-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jucrouzet",
        "blueset"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 868725481,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Jun 25, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @jucrouzet @blueset — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 25, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@sandersn sandersn closed this Jun 28, 2021
@sandersn sandersn reopened this Jun 28, 2021
@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Jun 28, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed The CI failed When GH Actions fails Untested Change This PR does not touch tests labels Jun 28, 2021
@sandersn
sandersn merged commit 4377a41 into master Jun 28, 2021
@sandersn
sandersn deleted the make-wicg-mediasession-work-with-4.4-dom branch June 28, 2021 20:06
@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/[email protected] to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants