Skip to content

Make dom-mediacapture-record work on TS 4.4's DOM #54096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 1 commit into from
Jun 28, 2021
Merged

Make dom-mediacapture-record work on TS 4.4's DOM #54096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions types/dom-mediacapture-record/dom-mediacapture-record-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const onDataAvailable = (event: BlobEvent) => {
const blobType = event.data.type;
};

const onError = (event: MediaRecorderErrorEvent) => {
const errorMessage = event.error.message;
const onError = (event: Event) => {
const errorMessage = (event as MediaRecorderErrorEvent).error.message;
};

const onEvent = (event: Event) => {};
Expand Down Expand Up @@ -62,7 +62,7 @@ recorder.onstart = null;
recorder.onstop = null;

recorder.addEventListener('dataavailable', (e: BlobEvent) => {});
recorder.addEventListener('error', (e: MediaRecorderErrorEvent) => {});
recorder.addEventListener('error', (e: Event) => {});
recorder.addEventListener('pause', onEvent);
recorder.addEventListener('resume', onEvent);
recorder.addEventListener('dataavailable', onEvent);
47 changes: 28 additions & 19 deletions types/dom-mediacapture-record/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,36 @@
// Definitions by: Elias Meire <https://github.com/elsmr>
// AppLover69 <https://github.com/AppLover69>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// Minimum TypeScript Version: 4.4

interface MediaRecorderErrorEventInit extends EventInit {
error: DOMException;
}

declare class MediaRecorderErrorEvent extends Event {
constructor(type: string, eventInitDict: MediaRecorderErrorEventInit);
interface MediaRecorderErrorEvent extends Event {
readonly error: DOMException;
}

declare var MediaRecorderErrorEvent: {
prototype: MediaRecorderErrorEvent;
new(type: string, eventInitDict: MediaRecorderErrorEventInit): MediaRecorderErrorEvent;
};

interface BlobEventInit extends EventInit {
data: Blob;
timecode?: number;
}

declare class BlobEvent extends Event {
constructor(type: string, eventInitDict: BlobEventInit);
interface BlobEvent extends Event {
readonly data: Blob;
readonly timecode: number;
readonly timecode: DOMHighResTimeStamp;
}

declare var BlobEvent: {
prototype: BlobEvent;
new(type: string, eventInitDict: BlobEventInit): BlobEvent;
};

type BitrateMode = 'vbr' | 'cbr';

interface MediaRecorderOptions {
Expand All @@ -34,33 +43,29 @@ interface MediaRecorderOptions {
audioBitrateMode?: BitrateMode;
}

type RecordingState = 'inactive' | 'recording' | 'paused';

interface MediaRecorderEventMap {
"dataavailable": BlobEvent;
"error": MediaRecorderErrorEvent;
"error": Event;
"pause": Event;
"resume": Event;
"start": Event;
"stop": Event;
}

declare class MediaRecorder extends EventTarget {
interface MediaRecorder extends EventTarget {
readonly stream: MediaStream;
readonly mimeType: string;
readonly state: RecordingState;
readonly videoBitsPerSecond: number;
readonly audioBitsPerSecond: number;
readonly audioBitrateMode: BitrateMode;

ondataavailable: ((event: BlobEvent) => void) | null;
onerror: ((event: MediaRecorderErrorEvent) => void) | null;
onpause: EventListener | null;
onresume: EventListener | null;
onstart: EventListener | null;
onstop: EventListener | null;

constructor(stream: MediaStream, options?: MediaRecorderOptions);
ondataavailable: ((this: MediaRecorder, event: BlobEvent) => any) | null;
onerror: ((this: MediaRecorder, event: Event) => any) | null;
onpause: ((this: MediaRecorder, event: Event) => any) | null;
onresume: ((this: MediaRecorder, event: Event) => any) | null;
onstart: ((this: MediaRecorder, event: Event) => any) | null;
onstop: ((this: MediaRecorder, event: Event) => any) | null;

addEventListener<K extends keyof MediaRecorderEventMap>(type: K, listener: (this: MediaRecorder, ev: MediaRecorderEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
Expand All @@ -72,10 +77,14 @@ declare class MediaRecorder extends EventTarget {
resume(): void;
pause(): void;
requestData(): void;

static isTypeSupported(type: string): boolean;
}

declare var MediaRecorder: {
prototype: MediaRecorder;
new(stream: MediaStream, options?: MediaRecorderOptions): MediaRecorder;
isTypeSupported(type: string): boolean;
};

interface Window {
MediaRecorder: typeof MediaRecorder;
BlobEvent: typeof BlobEvent;
Expand Down