[leaflet] Forward given feature property type - #69237

@someonewithpc Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• leaflet — on npm, on unpkg (author is owner)
  • owner-approval: @henrythasler
  • Config files to check:
    • leaflet/.eslintrc.json: edited

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 69237,
  "author": "someonewithpc",
  "headCommitOid": "d8da7c4eb2e48275d529d68ccf19600ac8ffc13c",
  "mergeBaseOid": "4d2a8f9d629c339b22c772d2479b4ffb617c5cfb",
  "lastPushDate": "2024-04-01T23:17:04.000Z",
  "lastActivityDate": "2024-04-14T08:23:46.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-04-14T06:29:02.000Z",
  "mergeRequestDate": "2024-04-14T08:23:46.000Z",
  "mergeRequestUser": "someonewithpc",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "leaflet",
      "kind": "edit",
      "files": [
        {
          "path": "types/leaflet/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/leaflet/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/leaflet/leaflet-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alejo90",
        "atd-schubert",
        "mcauer",
        "ronikar",
        "life777",
        "henrythasler",
        "captain-igloo",
        "someonewithpc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "henrythasler",
      "date": "2024-04-14T06:28:21.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2030773962,
  "ciResult": "pass"
}

🔔 @alejo90 @atd-schubert @mcauer @ronikar @life777 @henrythasler @captain-igloo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@someonewithpc Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

Re-ping @alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@someonewithpc Can you provide a bit of context as to why this change is useful/needed?

@someonewithpc Can you provide a bit of context as to why this change is useful/needed?

It just seemed like a small improvement to me, to allow the factory function to have the same functionality as the constructor. Doesn't change much, and it's definitely not needed, but I think it's still useful

(This came up when going through #69221)

@someonewithpc: Everything looks good here. I am ready to merge this PR (at d8da7c4) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo: you can do this too.)

Ready to merge