[leaflet] Turn on strictNullChecks and fix errors that arise - #69238

@someonewithpc Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• leaflet — on npm, on unpkg (author is owner)
  • owner-approval: @henrythasler

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 69238,
  "author": "someonewithpc",
  "headCommitOid": "b04a8cb823997ae480a95c176829196e7a639e07",
  "mergeBaseOid": "be8f9157dfa2a5d8682aef94f4036e52c87acca7",
  "lastPushDate": "2024-04-01T23:22:34.000Z",
  "lastActivityDate": "2024-04-22T13:42:03.000Z",
  "mergeOfferDate": "2024-04-20T20:26:00.000Z",
  "mergeRequestDate": "2024-04-22T13:42:03.000Z",
  "mergeRequestUser": "someonewithpc",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "leaflet",
      "kind": "edit",
      "files": [
        {
          "path": "types/leaflet/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/leaflet/leaflet-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/leaflet/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "alejo90",
        "atd-schubert",
        "mcauer",
        "ronikar",
        "life777",
        "henrythasler",
        "captain-igloo",
        "someonewithpc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "henrythasler",
      "date": "2024-04-20T20:25:18.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2030779505,
  "ciResult": "pass"
}

🔔 @alejo90 @atd-schubert @mcauer @ronikar @life777 @henrythasler @captain-igloo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@someonewithpc The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@someonewithpc The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@RyanCavanaugh This seems to have been a spurious failure, as it's reporting an error in the leaflet package when supposedly testing leaflet-boundary-canvas. Invalid cache? See https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/8515025908/job/23321773775#step:11:93

Re-ping @alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @someonewithpc.

(Ping @alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo.)

@someonewithpc: Everything looks good here. I am ready to merge this PR (at b04a8cb) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo: you can do this too.)

Ready to merge