Repository navigation
Fix restart prompt when loading text settings - #5508
Open
raven (r4venrudy) wants to merge 1 commit into
Open
raven (r4venrudy) wants to merge 1 commit into
raven (r4venrudy) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Experimental settings loads the icon database URL into a
TextboxCard. Avalonia queuesTextChanged, so the handler added after assigning the initial text still receives that event. It saves the unchanged value and executes the command that displays the restart prompt.Compare the sanitized text with the saved setting before writing or notifying. Loading an unchanged value now leaves the restart prompt hidden, while edits and clearing the field still save and notify once.
Add four headless regression cases covering empty and nonempty initial values, edits and clearing, and numeric filtering. Each test uses an isolated settings directory and headless UI session.
Validation:
UniGetUI.Tests: 727 passed.Managers_AddAndRemoveASource, waiting for the fakemsstoresource. The same timeout reproduces when rebuilding and running that test with the original, unmodifiedTextboxCard.Win-x64-NativeAotpublish was attempted but is blocked locally byPlatform linker not found(Visual Studio Desktop Development for C++ is unavailable). Published NativeAOT runtime validation, including the other runtime profiles, remains unverified.Closes #5507