Repository navigation
Publish Package Dialog UI Refresh #2 - #12206
Merged
QilongTang merged 28 commits intoNov 1, 2021
Merged
Conversation
QilongTang
reviewed
Oct 29, 2021
QilongTang
reviewed
Oct 29, 2021
QilongTang
reviewed
Oct 29, 2021
QilongTang
left a comment
Contributor
There was a problem hiding this comment.
Once comments addressed, we should be good to go
Contributor
|
Hi @sm6srw Let me know if you have anything on your end. |
QilongTang
approved these changes
Nov 1, 2021
Contributor
|
@QilongTang Nothing from me! I somehow assigned myself to the wrong Jira task. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR cherry-picks changes made from PR #12171, since that was based off a custom branch.
This PR Updates the styling of PackagePublishView and introduces new optional fields as per the visual refresh design:
Please Note: A follow-up PR will be needed to address the current discussion around loading/unloading DLLs. Current implementation of the Markdown functionality is setting a string property on the PublishPackageViewModel, the build process remains untouched for now.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Amoursol