Repository navigation
DYN-10990: Add AA modification marker to Graph Node Manager - #17385
ivaylo-matov wants to merge 8 commits into
Conversation
github-actions
Bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://autodesk.atlassian.net/browse/DYN-10990
ivaylo-matov
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
The marker has a layout gap and accessibility omission, while its test is categorized as a known failure and does not exercise the UI.
3 open findings
What changed in this PR
Adds an Autodesk Assistant modification marker to Graph Node Manager rows.
Changes:
- Adds the marker and localized tooltip.
- Propagates AI-modification state through
GridNodeViewModel. - Adds notification coverage for state changes.
| File | Description |
|---|---|
GraphNodeManagerViewExtensionTests.cs |
Tests state forwarding. |
GridNodeViewModel.cs |
Exposes AI-modification state. |
Resources.resx |
Adds default tooltip text. |
Resources.en-US.resx |
Adds English tooltip text. |
Resources.Designer.cs |
Exposes the resource property. |
GraphNodeManagerView.xaml |
Renders the marker in node rows. |
Files not reviewed (1)
- src/GraphNodeManagerViewExtension/Properties/Resources.Designer.cs: Generated file
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
…modification-marker-to-Graph-Node-Manager_
…aph-Node-Manager_
|
unrelated DYN-10842 flake - passes locally. I will rerun SelfServe. |
|
Purpose
This is a small PR to address DYN-10990
Adds an indicator in Graph Node Manager for nodes recently created or modified by Autodesk Assistant, complementing the temporary canvas highlight.
NodeModel.IsRecentlyModifiedByAI, so it appears and clears together with the canvas highlight (transient, not saved to the .dyn).Test: added
GraphNodeManagerAIMarkerTests.RecentlyModifiedByAIIconVisibilityTest- checks the rendered icon visibility and image source in the Graph Node ManagerDeclarations
Check these if you believe they are true
Release Notes
Graph Node Manager now marks nodes recently created or modified by Autodesk Assistant.
Reviewers
@DynamoDS/eidos
@jasonstratton
@johnpierson
FYIs
@dnenov