Repository navigation
DYN-10964: Undo/redo clears AI highlight for all node edits - #17387
Open
ivaylo-matov wants to merge 2 commits into
Open
ivaylo-matov wants to merge 2 commits into
ivaylo-matov wants to merge 2 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://autodesk.atlassian.net/browse/DYN-10964
|
ivaylo-matov
marked this pull request as ready for review
October 9, 2026 07:43
ivaylo-matov
requested review from
jasonstratton
and
a balanced review from Copilot
October 9, 2026 07:43
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Redo clearing is implemented but not directly exercised with an active highlight.
1 open finding
What changed in this PR
Ensures undo/redo clears AI-modified node highlights when restoring edited nodes.
Changes:
- Clears
IsRecentlyModifiedByAIafter undo/redo deserialization. - Adds coverage for common node edits and untouched nodes.
| File | Description |
|---|---|
src/DynamoCore/Graph/Workspaces/UndoRedo.cs |
Clears AI highlights when restoring nodes. |
test/DynamoCoreTests/Graph/Nodes/AIHighlightUndoRedoTests.cs |
Tests highlight behavior across undo/redo scenarios. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // does not raise Modified, which is what clears the highlight for other edits. | ||
| if (model is NodeModel node) | ||
| { | ||
| node.IsRecentlyModifiedByAI = false; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a small PR to follow-up to #17360 (AI-modified node highlight).
Undo/redo did not clear the AI highlight when the undone edit was a rename, lacing, preview, freeze or position change. Those edits don't raise
Modified, which is what normally clears the highlight.Fix:
WorkspaceModel.ReloadModel(used by every undo/redo of a node) now clearsIsRecentlyModifiedByAIon the node it restores. Undo and redo now count as the user touching the node.Tests added in
AIHighlightUndoRedoTests:Declarations
Check these if you believe they are true
Release Notes
Undo/redo now clears the AI-modified highlight on nodes for all edit types.
Reviewers
@DynamoDS/eidos
@jasonstratton
@johnpierson
FYIs
@dnenov