Repository navigation
Duplicate connections using ctrl + click - #7714
Conversation
|
Very nice @yeexinc. One thing that maybe we should consider regarding this and the multi-ouput port reconnect functionality is being able to hit ESC to completely get out of the command. Let me know what you think. Can't wait to play with this. |
|
@Racel Hitting Esc in the current scenario is same as what we do with Single wire connection. For Ctrl+Click hitting Esc will terminate the duplicating operation, I hope that is what expected here. Do let us know if you have additional comments. |
|
@riteshchandawar - I believe that hitting ESC should terminate the duplicating operation. Will it disconnect the wires that were connected during the operation? Regarding the multi-ouput port reconnect feature, I think ESC should place the wire back where it came from. |
|
Hi @Racel , currently the ESC button only cancels the current connection (and does not place the wire back). This is the same behaviour as pressing ESC while doing single wire connection as mentioned by @riteshchandawar . It will not disconnect the other wires that were connected during the operation. The user can obtain the previous connections by hitting undoes, though. Each undo will restore one connection. E.g. if the user makes 4 connections using ctrl + click, then 4 undoes will be needed to restore the previous state. |
|
@yeexinc - This behavior is fine for this duplicate connection feature. But, I plan on filing a separate task to adjust the behavior of the multi-output port reconnect. |
|
yeexinc - This looks good. When are you all planning on merging so we can try out? FYI @wynged - thanks for your ideas on this. Take a look. |
|
@Racel - I think the PR needs to be reviewed. @riteshchandawar Would you mind taking a look? |
|
@riteshchandawar - Please review so that we can test :) |
|
Looks good to me, I am merging this now. |
Purpose
This PR is to address DYN-622.

Multiple connections can be created by holding down the control key and clicking on the desired ports.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@riteshchandawar
FYIs
@Racel