Repository navigation
Fix node help prompt - #7749
Merged
Merged
Fix node help prompt#7749
Conversation
yeexinc
approved these changes
Apr 5, 2017
Contributor
|
LGTM, I think the fixes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a couple of data binding errors in
NodeHelpPrompt.A larger problem revealed during the investigation of this defect is that for dialogues created as a result of interaction with a node, I don't believe
PortViewModelis being set as the data context. Instead, the data context for such views in theNodeModel, and subsequently, thePortModels on those nodes. But the xaml is written as if it is using thePortViewModel, which suggests that these views haven't worked correctly for some time.PTAL
@yeexinc I'm giving this one to you as it seems that you have may have been the last one in this code.