Skip to content

Import/Export category - #7751

Closed
yeexinc wants to merge 4 commits into
DynamoDS:LibraryReorgfrom
yeexinc:importexport-category
Closed

yeexinc wants to merge 4 commits into
DynamoDS:LibraryReorgfrom
yeexinc:importexport-category

Conversation

@yeexinc

@yeexinc yeexinc commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

Purpose

Currently the Import/Export category exists in Core > ImportExport. This PR is to create a separate category for ImportExport instead of having it in Core.
(Please take a look.)

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@aparajit-pratap

FYIs

@benglin @fanwgwg

@yeexinc yeexinc closed this Apr 6, 2017
@yeexinc

yeexinc commented Apr 6, 2017 •

Copy link
Copy Markdown
Contributor Author

Closing this since it's not a necessary implementation for the new library UI.

@yeexinc yeexinc reopened this Apr 10, 2017
@aparajit-pratap

Copy link
Copy Markdown
Contributor

@yeexinc @fanwgwg sorry, I'm going back on my decision again. I suggest keeping the namespace names unchanged for now and only change the class names as per the discussion here. Closing this PR ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants