Skip to content

Rename ShouldKeepListStructure - #7919

Merged
ramramps merged 5 commits into
DynamoDS:masterfrom
ramramps:rename-list-structure
Jun 7, 2017
Merged

ramramps merged 5 commits into
DynamoDS:masterfrom
ramramps:rename-list-structure

Conversation

@ramramps

@ramramps ramramps commented Jun 1, 2017

Copy link
Copy Markdown
Collaborator

Purpose

https://jira.autodesk.com/browse/QNTM-697

  • Renamed ShouldKeepListStructure to KeepListStructureon PortModel
  • Fixed the tests.
  • Validated : XML Serialzation / DeSerialization

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@ramramps ramramps changed the title [WIP] Rename list structure [WIP] Rename ShouldKeepListStructure Jun 1, 2017
@gregmarr

gregmarr commented Jun 1, 2017

Copy link
Copy Markdown
Contributor

I'm not sure why this Jira task says that this is to match the CoGS structure:

https://git.autodesk.com/AEC-Generative-Design/ComputationGraphService/blob/master/api/service.yaml#L1778

      ShouldKeepListStructure:
        type: "boolean"
        description: "Whether data from this node will be re-aligned into the original structure of the nested list."

@gregmarr

gregmarr commented Jun 1, 2017

Copy link
Copy Markdown
Contributor

In #7747, @ikeough is proposing the rename in both Dynamo and CoGS. I'm not sure of the purpose of this rename.

@ramramps

ramramps commented Jun 2, 2017

Copy link
Copy Markdown
Collaborator Author

@gregmarr There are other renames in the current sprint. May be you should take a look at them.

// in AssemblyVersionInfo.cs so that it can be easily incremented by the
// automated build process.
[assembly: AssemblyVersion("2.0.0.3911")]
[assembly: AssemblyVersion("2.0.0.5176")]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't commit this file - it just causes merge conflicts.

// automated build process.

[assembly: AssemblyVersion("2.0.0.4057")]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the merge conflicts.

@@ -1,23 +1,14 @@
:: Argument %1: path to template folder

@ramramps ramramps Jun 5, 2017 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this is showing here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you rolled this file into a previous version, can you revert the change to this file only?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, can you try to get rid of this change.

exit /b 1
)
)
) No newline at end of file

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got rid of that change...this file is same as master.

@ramramps ramramps changed the title [WIP] Rename ShouldKeepListStructure Rename ShouldKeepListStructure Jun 7, 2017
@ramramps

ramramps commented Jun 7, 2017

Copy link
Copy Markdown
Collaborator Author

Merging this now.

@ramramps
ramramps merged commit dc1bb5b into DynamoDS:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants