Repository navigation
Workspace Refactoring - #7937
Conversation
|
@ikeough do you have access to the self service CI EC job? |
| private bool isVisibleInDynamoLibrary; | ||
|
|
||
| protected override void RequestRun() | ||
| internal override void RequestRun() |
There was a problem hiding this comment.
whats the need for this change?
There was a problem hiding this comment.
It was upgraded to internal in the base class as well, as it's called from the NodeToCodeExtensions.
| using Newtonsoft.Json; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Text.RegularExpressions; |
There was a problem hiding this comment.
Aha, apparently your sorting plugin decides to put system usings after Dynamo usings which is default for most plugins. Either way is acceptable among developers, but just hope that we specify that in the coding standard.
| /// </summary> | ||
| /// <returns>A string representing the serialized WorkspaceModel.</returns> | ||
| public static string SaveWorkspaceToJson(WorkspaceModel workspace, LibraryServices libraryServices, | ||
| public static string ToJson(this WorkspaceModel workspace, LibraryServices libraryServices, |
|
@ikeough LGTM. I appreciate the fact your are making |
and I shall re-work the changes based on the new signatures.
|
@ikeough I saw one failing test on your run last night on the CI, was that fixed? |
|
@mjkkirschner I haven't fixed that test yet. Will do so before merging. |
|
I am leaving the one failing test |
3 participants
Purpose
This PR moves graph layout, presets, and node to code out to separate extensions classes. It moves the undo recorder to separate .cs files, but keeps it as a partial class of
WorkspaceModel.It also moves and renames the json serialization methods recently added by @QilongTang to core. These are now the static method
WorkspaceModel.FromJson(...)and the extension methodmyWorkspace.ToJson(...).Declarations
Check these if you believe they are true
*.resxfiles n/aReviewers
@QilongTang