Repository navigation
Rename InputPorts and OutputPorts - #7942
Merged
Merged
Conversation
gregmarr
requested changes
Jun 9, 2017
gregmarr
left a comment
gregmarr
left a comment
Contributor
There was a problem hiding this comment.
Can someone please explain why this change is a good idea? To me it loses information (that the collection contains ports) and conflates the graph inputs and outputs with the node input and output ports, which are completely different types, by naming them the same.
Member
Collaborator
Author
|
@ikeough Ping. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR renames InputPorts to Inputs and OutputPorts to Outputs.
https://jira.autodesk.com/browse/QNTM-698
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @mjkkirschner