Repository navigation
Implement IServiceManager interface - #7946
Merged
Merged
Conversation
7 tasks
Member
|
@sharadkjaiswal what is this going to be used for? |
Contributor
Author
|
@mjkkirschner many times some services are implemented in Extension application library and we don't have a good consistent way to access those services. For example, if we want to access PackageLoader from any other library we need to know the name of PackageManager extension application and then iterate over all extensions to get the extension with matching name from extension manager and then cast it to PackageManagerExtension to finally get to PackageLoader. |
Contributor
Author
|
@mjkkirschner please look at PR #7963 for a reference use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR provides a mechanism to register and retrieve service objects via IExtensionManager interface to provide some custom functions. Implements a new interface IServiceManager and IExtensionManager inherits this interface.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@ikeough
@pboyer