Repository navigation
Nickname and PortName should be serialized to Name - #7947
Merged
Merged
Conversation
stop reading name when reading json for nodes
# Conflicts: # src/DynamoCore/Graph/Workspaces/Serialiaztion/SerializationConverters.cs
QilongTang
reviewed
Jun 12, 2017
| /// </summary> | ||
| /// <param name="id">Identifier of the custom node instance.</param> | ||
| /// <param name="name">The name represents the GUID of the custom node | ||
| /// <param name="functionId">The functionId represents the GUID of the custom node |
QilongTang
reviewed
Jun 12, 2017
| /// Sets the name of this node from the attributes on the class definining it. | ||
| /// </summary> | ||
| public void SetNickNameFromAttribute() | ||
| public void SetNamePropertyFromAttribute() |
Contributor
There was a problem hiding this comment.
Can we align the two functions' name SetNamePropertyFromAttribute and getNameFromNodeNameAttribute? Like get(set)NameFromNodeNameAttribute..
QilongTang
reviewed
Jun 12, 2017
|
|
||
| //notes | ||
| writer.WritePropertyName("Notes"); | ||
| writer.WritePropertyName("Notes"); |
Contributor
There was a problem hiding this comment.
There is an extra space here
Contributor
|
Looks good to me overall. Just a few comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/QNTM-694
This PR does a few things:
get rid of original
NameProperty onNodeModelwhich usually returned the value of the[NodeNameAttribute]- @gregmarr has detailed notes of the output for this. Instead this attribute value is gathered from a private method onNodeModel.Nicknameis now theNameproperty.PortNameis renamed toNamePortModel.NameandNodeModel.Nameboth serialize toName- butNodeModel.Namedoes Not serialize into the graph block, it should only serialize when the nodeViewModel is serialized.Nameexists on theNodeViewModeland grabs a value off theNodeModelFixes an issue when the workspace is serialized, if the
WorkspaceModelis a CustomNode, it will serialize the CustomNodeId or functionId as the Uuid.updates some recorded tests to use the new Name property instead of Nickname when setting the name.
Declarations
There will be two related PRs in other repos.
Check these if you believe they are true
*.resxfilesReviewers
@ramramps
FYIs
@ikeough @QilongTang @gregmarr