Repository navigation
Add Engine reference to workspace writer converter. - #7957
Merged
Merged
Conversation
QilongTang
reviewed
Jun 13, 2017
| /// </summary> | ||
| /// <returns>A string representing the serialized WorkspaceModel.</returns> | ||
| public static string ToJson(this WorkspaceModel workspace) | ||
| internal static string ToJson(this WorkspaceModel workspace, EngineController engine) |
Contributor
There was a problem hiding this comment.
OK. I think we can stick to this for now
Contributor
|
Looks good to me |
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds an engine reference to the
WorkspaceWriteConverterfor the purpose of serializing binding data.FYIs
@QilongTang