Repository navigation
Cross merge LibraryReorg branch to master - #8018
Merged
Merged
Conversation
* Recategorize built-in methods * Added methods for List.cs, Math.cs and ImportExport.cs * Updated Math.MapTo * Updated List.cs * Icons and test cases - built-in methods are hidden from user's search - test cases moved to DSCoreNodesImages.resx - minor refinement to some methods - added test cases for List.cs and Math.cs * Set copy local in DynamoCoreWpfTests to false * Updated methods and test cases - Implementation for SetUnion, SetIntersection and SetDifference are the same as built-in methods - Edited ImportExport.ImportFromCSV to reuse the implementation from built-in - Added test cases for ImportExport.ImportFromCSV and fixed other test cases - Consolidated List.Contains with List.ContainsItem - Consolidated NormalizeDepth(list, rank) with NormalizeDepth(list) - Hid some of the built-in methods - Public methods and private helper methods are grouped using regions - Overload of List.Flatten is renamed as FlattenCompletely * Fixes for built in method test cases * Hide SortIndexByValue overload from builtin * Edited List, Math and ImportExport functions - consolidated CSV.ReadFromFile with ImportExport.ImportFromCSV - renamed ImportFromCSV to ImportCSV - moved CSV.WriteToFile to ImportExport.ExportCSV - fixed some of the list functions - reused builtin implememtations for Math.Map and Math.MapTo - moved test cases for CSV functions to ImportExport * migrations for csv.writetofile replacement of CSV.WriteToFile to ImportExport.ExportCSV * migrations for builtin nodes * Renamed FlattenCompletely and removed GetValues * updated icon for list.flatten * Update List.Flatten test case and revert migration for File.ExportToCSV
Consolidate Display nodes for re-categorization
* LibraryViewExtension project for hosted library UI * Serve library view with local data
* Details view implementation over Dynamo canvas * Fix visibility of details view
* installed packages in json format * updated method to obtain installed pkg * removed getInstalledPackagesJSON() * reverted change to library.html * reverted previous changes
* move some methods from Logic and Formula to Math * add entries to migration xml * add migration testcase
* remove list.flatten overload * Updated Dynamo.All.Sln * add migration test case
* Rename "ColorRange2D" to "ColorRange" * Add migration test case for ColorRange nodes
* Added 15 more packages to the list. * updated files to show packages.
* move nodes from file to importexport * add a migration testcase * change category name on ui to Import/Export * revert the slash * change namespace back to DSCore * rename namespace back to DSCore.IO * update loadedtypes.json
) * consolidate directory nodes and rename importexport class * updated DirectoryFromPath and added migrations * change namespace from DSCore.IO to ImportExport * rename namespace and move directory methods to files.cs * add migration test cases * add directory.frompath and update nodemigrationtests * resolve conflicts * updated files
Update layoutSpecs and loadedTypes to recategorize "ColorRange2D" nodes into "ColorRange"
* Implement event notification for libraryDataUpdated * update documentation * Event Observer * More testc ases * Don't use old results when throttle re-fires * Address review comments
…o LibraryReorg # Conflicts: # src/LibraryViewExtension/Handlers/NodeItemDataProvider.cs
Use the host search function
* fix failing excel tests * fixed tests * changed comments
* fix failing excel tests * fixed tests * changed comments * added builtin overload for List.Equals
…7956) * fix failing excel tests * fixed tests * changed comments * added builtin overload for List.Equals * remove SearchView and LibrarySearchView WPF views * restore deleted comments
Merging master into library reorg branch
Fix build issues introduced by #7960
* Include assembly name in fully qualified name * Create ZeroTouchSearchElement.cs
* LibraryViewCustomization Service implementation * Address review comments * Address more review comments
* Provides support for default icon when resource not found * Include concurrency test
Add node icon for Label.ByPointAndString
* Update library resource and categorization * Remove ImportExportTests as its already moved to DSOfficeTests * update librarie.min.js
…sm (#8014) * Implement Resource registration and app shutdown notification mechanism * Update LibraryViewExtension.Dispose implementation * Address review comments
removed unnecessary migration path for ExportCSV node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR brings in all the awesome work done for Library re-categorization and new UI by my fellow colleagues in Singapore.
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@benglin
@Racel
@kronz