Skip to content

psql test cases #334

Open
Open
psql test cases#334

Description

@yilinxia
yilinxia
opened on Jun 20, 2024

psql tests have been used to help implement duckdb. This issue aims to record all test related issues

  1. For test psql_arg_min_max_k_test.l, it should be Test(opt: "Min", arg_opt: TestArgMin(), arg_opt_k: TestArgMinK()); instead of Test(opt: "Max", arg_opt: TestArgMin(), arg_opt_k: TestArgMinK()); for the second rule

Activity

  1. EvgSkv commented on Jun 20, 2024

    @EvgSkv
    EvgSkv
    on Jun 20, 2024
    Owner

    Thanks for reporting! Fixed it.

  2. yilinxia commented on Jun 21, 2024

    @yilinxia
    yilinxia
    on Jun 21, 2024
    ContributorAuthor
    1. DuckDB is using True and False for Boolean instead of 0 and 1. When running the test psql_bool_test, we need ensure that it is comparable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions