Repository navigation
Databricks dialect - #284
Conversation
EvgSkv
left a comment
EvgSkv
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Please see a couple requests to comment inline. Overall looks great!
| @@ -0,0 +1,26 @@ | |||
| library = """ | |||
There was a problem hiding this comment.
For Apache compliance please add leading comment:
#!/usr/bin/python
#
# Copyright 2023 Logica Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
|
|
||
|
|
||
| class Databricks(Dialect): | ||
| """Databricks dialect""" |
There was a problem hiding this comment.
Can you please add a brief comment explaining current state of the dialect. I.e. what are critical features yet to be implemented?
E.g.:
- Unnesting. Does this work?
Q(x) :- x in [1,2,3];
- Records.
Does this work?
P({a:1, b: ["x","y"]});
I am assuming something is yet TODO, is that so?
|
hey @EvgSkv, i add Apache compliance comment and checked Unnesting and Records. also i added minor TODO, but they are not critical. Serhii. |
|
Looking great! I'll be resolving conflicts and merging the PR this week. Thank you @KantorSerhiy ! |
2 participants
Hi @EvgSkv!
In the continuation of the discussion #236 -> I add the databricks dialect.
I am waiting for feedback from you!
Thank you.
Serhii.