Skip to content

Cleanup stuff after GHC-8.0 - #216

Merged
phadej merged 1 commit into
GetShopTV:masterfrom
phadej:cleanups-ghc-8.10
May 17, 2020
Merged

phadej merged 1 commit into
GetShopTV:masterfrom
phadej:cleanups-ghc-8.10

Conversation

@phadej

@phadej phadej commented May 16, 2020

Copy link
Copy Markdown
Collaborator
  • Bump lower bounds of boot libraries
  • Remove (all!) of CPP, including overlapping-compat.h
  • Make few small cleanups elsewhere
  • Remove .ghci, use stack repl or cabal repl
  • Regenerate .travis.yml

@phadej
phadej force-pushed the cleanups-ghc-8.10 branch 4 times, most recently from 4e915f6 to c697c01 Compare May 16, 2020 13:02
- Bump lower bounds of boot libraries
- Remove (all!) of CPP, including overlapping-compat.h
- Make few small cleanups elsewhere
- Remove .ghci, use `stack repl` or `cabal repl`
- Regenerate .travis.yml
@phadej
phadej force-pushed the cleanups-ghc-8.10 branch from c697c01 to 44ad73c Compare May 16, 2020 20:13
@phadej

phadej commented May 16, 2020

Copy link
Copy Markdown
Collaborator Author

CI green

@fisx fisx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little uncertain about my role / authority in this project, so I'll not merge this, but I like the changes a lot, thanks!

@phadej do you still have write access to the repo? Let me know if you want me to merge it. :)

@fizruk

fizruk commented May 17, 2020

Copy link
Copy Markdown
Member

Remove (all!) of CPP, including overlapping-compat.h

😱 This is amazing!

@phadej Thank you! 😊

@phadej
phadej merged commit 228a301 into GetShopTV:master May 17, 2020
@phadej phadej changed the title Cleanup stuff after GHC-8.10 Cleanup stuff after GHC-8.0 May 17, 2020
@phadej
phadej deleted the cleanups-ghc-8.10 branch May 17, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants