Repository navigation
feat: add support for service account impersonation - #192
Merged
Merged
Conversation
kurtisvg
approved these changes
Dec 7, 2022
hessjcg
previously requested changes
Dec 7, 2022
hessjcg
left a comment
hessjcg
left a comment
Member
There was a problem hiding this comment.
See if you can get rid of the redundant switch statement.
| if c.ImpersonateTarget != "" { | ||
| var iopts []option.ClientOption | ||
| switch { | ||
| case c.Token != "": |
Member
There was a problem hiding this comment.
Seems like this switch statement from line 130-150 are much identical to lines 166-189. Could you somehow
combine those into a separate function?
iopts := c.withCredentialSource(l) // switch statement in here
if c.ImpersonateTarget != "" {
ts, err := impersonate.CredentialsTokenSource( ... iopts)
// ... error handling, etc
return alloydbconn.WithTokenSource(ts)
}
return iopts
Contributor
There was a problem hiding this comment.
If we are making significant changes to this PR we should make sure to update the Cloud SQL go connector as well
Member
Author
There was a problem hiding this comment.
Let's fix this in the v2 proxy and port the change here.
enocom
dismissed
hessjcg’s stale review
December 7, 2022 22:20
We'll land this change in the Cloud SQL proxy and port it back over here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1460.