Repository navigation
Support configuring proxy with environment variables #225
Copy link
Copy link
Closed
Labels
priority: p0Highest priority. Critical issue. P0 implies highest priority.Highest priority. Critical issue. P0 implies highest priority.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
Activity
- addedtype: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
on Nov 27, 2018 - addedpriority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.
on Feb 9, 2021 We're working on some major structural improvements to the proxy. Once those are complete, we'll come back to address this issue.
- changed the title
[-]Ideally Instances would be a variable in the docker container.[/-][+]Support configuring proxy with environment variables[/+]on Aug 29, 2022 - addedpriority: p0Highest priority. Critical issue. P0 implies highest priority.Highest priority. Critical issue. P0 implies highest priority.and removedpriority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.
on Aug 29, 2022 This work will unblock #1045.
What if we did a kind of naming scheme for the environment variables:
# global flag CLOUD_SQL_PROXY_PORT=5000 CLOUD_SQL_PROXY_CREDENTIALS_FILE=./keys/service_account.json # global flag # instance specific flags CLOUD_SQL_PROXY_INSTANCE_1=hello:world:db1 # instance flag CLOUD_SQL_PROXY_INSTANCE_1_PORT=8080 CLOUD_SQL_PROXY_INSTANCE_1_PRIVATE_IP=true #Boolean env var? CLOUD_SQL_PROXY_INSTANCE_2=hello:world:db2 CLOUD_SQL_PROXY_INSTANCE_2_PORT=8081 CLOUD_SQL_PROXY_INSTANCE_2_USE_IAM_AUTHN=trueReacted by Eno ComptonI think we should make the list of instance connection names zero indexed and also define an INSTANCE_CONNECTION_NAME variable for the first instance, for the cases when someone is connecting to only a single instance:
CLOUD_SQL_PROXY_INSTANCE_CONNECTION_NAME=proj:reg:myinst CLOUD_SQL_PROXY_INSTANCE_0=proj:reg:myinst CLOUD_SQL_PROXY_INSTANCE_1=proj:reg:myotherinstAlso, to configure individual instances, we'll continue to use query params:
CLOUD_SQL_AUTO_IAM_AUTHN=true CLOUD_SQL_PROXY_INSTANCE_0=proj:reg:myinst?auto-iam-authn=false- added 2 commits that reference this issue
on Oct 26, 2022 - added a commit that references this issue
on Nov 7, 2022 - added a commit that references this issue
on Nov 7, 2022 - added a commit that references this issue
on Feb 26, 2023
Metadata
Metadata
Assignees
Labels
priority: p0Highest priority. Critical issue. P0 implies highest priority.Highest priority. Critical issue. P0 implies highest priority.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
With instances being a command line argument I cannot use k8s secrets to set the instance and then recycle the same deployment.yaml file between environments, but rather resort to a generator for the k8s config.
An example can be found at:
https://github.com/itkj/docker-cloud-sql-proxy/blob/master/Dockerfile#L10
from itkj/docker-cloud-sql-proxy on docker hub.