Repository navigation
fix: allow specifying protocol in the endpoint - #151
Merged
Merged
Conversation
mohanli-ml
reviewed
Oct 24, 2022
|
|
||
| private ManagedChannelBuilder<?> channelBuilderForEndpoint(String endpoint) { | ||
| String serviceAddress; | ||
| // Assume https by default. |
Contributor
There was a problem hiding this comment.
What is the schema is not http2?
Collaborator
Author
There was a problem hiding this comment.
The schema here is used just to determine the port if it is not specified. We will not pass the schema further.
mohanli-ml
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.