Repository navigation
Add h/l as panel-nav aliases to help and docs - #361
Merged
Merged
Conversation
input.rs already accepts l/h as Tab/Shift-Tab aliases for next/previous panel, but the in-app ? help and docs/usage.md only mentioned Tab and Shift-Tab, so the aliases were invisible to users.
The "Tab/S-Tab, l/h" key label overflowed the {key:<14} column used to
render the Global help section, so longer bindings after it in that
column could misalign. Shorten it to "Tab/S-Tab,l/h" (13 chars) and
assert the exact row instead of a loose contains-l-and-h check.
Owner
|
Merged, thank you @drakeo338! The help overlay and docs now list |
This was referenced Sep 29, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
h/lalready move to the previous / next panel (same asShift-Tab/Tab), but neither the help overlay nor the docs said so. Adds them to theHELP_TEXTentry incrates/vortix/src/ui/overlays.rsand to the key table indocs/usage.md, plus a test (panel_nav_help_mentions_h_and_l) checking the help text lists both.Related Issue
Fixes #354
Type of Change
Checklist
scripts/ci-local.shpasses (seedocs/ci-parity.md) —--quickshows 18 pre-existing failures unrelated to this change, also present on upstreammaindocs/usage.mdpanel-nav row now listsl/h)cargo test -p vortix overlays: 14 passed on upstreammain, 15 on this branch (the new test).cargo fmt --checkandcargo clippy -p vortix --all-targets -- -D warningsare both clean.