Skip to content

Fix maven-model and maven-artifact missing test scope - #1125

Merged
rbri merged 1 commit into
HtmlUnit:masterfrom
sepe81:fix/maven-deps-test-scope
May 26, 2026
Merged

rbri merged 1 commit into
HtmlUnit:masterfrom
sepe81:fix/maven-deps-test-scope

Conversation

@sepe81

@sepe81 sepe81 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #1124

maven-model and maven-artifact are only used in ExternalTest.java but were declared without <scope>test</scope>, causing them (and plexus-utils transitively) to leak into the compile scope of downstream projects.

This adds the missing <scope>test</scope> to both dependencies.

@sonarqubecloud

Copy link
Copy Markdown

@rbri
rbri merged commit 95a7f56 into HtmlUnit:master May 26, 2026
2 checks passed
@rbri

rbri commented May 26, 2026

Copy link
Copy Markdown
Member

Thanks....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maven-model and maven-artifact leaked into compile scope in 5.0.0

2 participants