Repository navigation
Fixes for CSSMediaRule (#360) - #362
Merged
Merged
Conversation
MediaList default toString() now prints the media text. CSSGroupingRule.cssRules, .insertRule() and .deleteRule() added (for CSSMediaRule). CSSConditionRule.conditionText added (for CSSMediaRule).
fdanek
changed the title
fdanek
marked this pull request as ready for review
June 30, 2021 12:36
Member
|
can you please rebase - and solve the conflicts |
rbri
reviewed
Jun 30, 2021
| @JsxSetter({FF, FF78, IE}) | ||
| @JsxSetter(IE) | ||
| public void setCssText(final String cssText) { | ||
| rule_.setCssText(cssText); |
Member
There was a problem hiding this comment.
I think the IE ignores the setter like all the other browsers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #360:
MediaList default toString() now prints the media text.
CSSGroupingRule.cssRules, .insertRule() and .deleteRule() added (for
CSSMediaRule).
CSSConditionRule.conditionText added (for CSSMediaRule).