Skip to content

Possible JavaScript Breakage Between 4.1.0 and 4.4.0 #844

Closed
Closed
Possible JavaScript Breakage Between 4.1.0 and 4.4.0#844

Description

@tntim96
tntim96
opened on Aug 9, 2024

I was using HTMLUnit 4.1.0 waiting for #808 to be solved and have now swapped 4.4.0 to get the fix. I've noticed now that, with no other change to my code-base in JSCover, that a test is failing.

You can probably checkout the branch 'htmlunit-4.4.0' of JSCover and debug to see what's going on.

The test is HtmlUnitUITest.shouldSortFilesByName.

I also tested with 4.5.0-SNAPSHOT but got the same error.

It's strange that a very similar test HtmlUnitUITest.shouldSortFilesByCoverage works.

Modifying https://github.com/tntim96/JSCover/blob/5fbf74c65a85cbfaa59a2c3911d8509d13a0bafb/src/main/resources/jscoverage.js line 839 to add console output...the JavaScript sort code is

      files.sort(function (file1, file2) {
        console.error('file1,2', file1.file, file2.file);
        return file1.file >= file2.file
      });

Output with HTMLUnit 4.4.0 is

20240809 15:09:45.706,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-empty.js",org.htmlunit.WebConsole,
20240809 15:09:45.707,1,SEVERE,"file1,2 /scripts/script-d.js /scripts/script-line.js",org.htmlunit.WebConsole,
20240809 15:09:45.708,1,SEVERE,"file1,2 /scripts/script-c.js /scripts/script-d.js",org.htmlunit.WebConsole,
20240809 15:09:45.708,1,SEVERE,"file1,2 /scripts/script-b.js /scripts/script-c.js",org.htmlunit.WebConsole,
20240809 15:09:45.709,1,SEVERE,"file1,2 /scripts/script-a.js /scripts/script-b.js",org.htmlunit.WebConsole,

...which looks wrong.

With HTML 4.1.0 it's

20240809 15:14:22.975,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-line.js",org.htmlunit.WebConsole,
20240809 15:14:22.976,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-d.js",org.htmlunit.WebConsole,
20240809 15:14:22.976,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-d.js",org.htmlunit.WebConsole,
20240809 15:14:22.977,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-c.js",org.htmlunit.WebConsole,
20240809 15:14:22.977,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-c.js",org.htmlunit.WebConsole,
20240809 15:14:22.978,1,SEVERE,"file1,2 /scripts/script-d.js /scripts/script-c.js",org.htmlunit.WebConsole,
20240809 15:14:22.978,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.979,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.979,1,SEVERE,"file1,2 /scripts/script-d.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.980,1,SEVERE,"file1,2 /scripts/script-c.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.980,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.980,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.981,1,SEVERE,"file1,2 /scripts/script-d.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.981,1,SEVERE,"file1,2 /scripts/script-c.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.982,1,SEVERE,"file1,2 /scripts/script-b.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.975,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-line.js",org.htmlunit.WebConsole,
20240809 15:14:22.976,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-d.js",org.htmlunit.WebConsole,
20240809 15:14:22.976,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-d.js",org.htmlunit.WebConsole,
20240809 15:14:22.977,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-c.js",org.htmlunit.WebConsole,
20240809 15:14:22.977,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-c.js",org.htmlunit.WebConsole,
20240809 15:14:22.978,1,SEVERE,"file1,2 /scripts/script-d.js /scripts/script-c.js",org.htmlunit.WebConsole,
20240809 15:14:22.978,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.979,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.979,1,SEVERE,"file1,2 /scripts/script-d.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.980,1,SEVERE,"file1,2 /scripts/script-c.js /scripts/script-b.js",org.htmlunit.WebConsole,
20240809 15:14:22.980,1,SEVERE,"file1,2 /scripts/script-line.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.980,1,SEVERE,"file1,2 /scripts/script-empty.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.981,1,SEVERE,"file1,2 /scripts/script-d.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.981,1,SEVERE,"file1,2 /scripts/script-c.js /scripts/script-a.js",org.htmlunit.WebConsole,
20240809 15:14:22.982,1,SEVERE,"file1,2 /scripts/script-b.js /scripts/script-a.js",org.htmlunit.WebConsole,

Which looks correct

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions