Repository navigation
#202 - added Javascript constructor for File - #203
twendelmuth wants to merge 2 commits into
Conversation
|
|
| } | ||
|
|
||
| @JsxConstructor({CHROME, FF, FF68}) | ||
| public File(NativeArray bytes, String name, NativeObject options) { |
There was a problem hiding this comment.
I'm not sure if there is a more appropiate Class for the potential options here. Optional didn't work.
| this.lastModified = Long.parseLong(secondsSince1970); | ||
| } else { | ||
| this.lastModified = System.currentTimeMillis() / 1000; | ||
| } |
There was a problem hiding this comment.
I'm not really happy with the whole options thing here ... happy to listen to improvements.
|
|
||
| @Test | ||
| @Alerts({"myfilename", "", "true", "0"}) | ||
| @NotYetImplemented(IE) |
There was a problem hiding this comment.
This one errors right now but is ignored. It still logs some errors though. Is there an easy way to not even run those tests without having to add a FileTest.properties?
| } | ||
| } | ||
|
|
||
| File(final String pathname) { |
There was a problem hiding this comment.
In general it might be a better read / easier to understand to have this in a subclass and move the whole java.io.File dependency there.
The option question then would still remain what we'd do with getFile() and how an abstract version of this should look like.
Right now I'm not saving the byte array since it's not really used.
|
Hi Thorsten, |
2 participants
#202